Cherry pick main 4.0.0 into stable-3 #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ible-collections#458) Remove useless tests/sanity/ignore-2.*.txt files lower than 2.14 SUMMARY Remove useless tests/sanity/ignore-2.*.txt files lower than 2.14 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Mario Lenz <m@riolenz.de> (cherry picked from commit bebe4bf)
Fixed broken link to scenario guide SUMMARY Fixed broken link to scenario guide. Because the page was deleted by ansible/ansible-documentation#975. ISSUE TYPE Docs Pull Request COMPONENT NAME README.md ADDITIONAL INFORMATION N/A Reviewed-by: Mario Lenz <m@riolenz.de> (cherry picked from commit 33767cd)
…e-collections#462) Fix options parsing to use vcenter_validate_certs false value SUMMARY Fixes the credentials options parsing to use vcenter_validate_certs=false if provided. It was previously defaulting to the env variable for any falsy value of vcenter_validate_certs, which meant both None (option not provided) and False (passed by the user) values were ignored. Fixes ansible-collections#425 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugin_utils.lookup Reviewed-by: Alina Buzachis Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Mario Lenz <m@riolenz.de> Reviewed-by: Brian Coca Reviewed-by: Bikouo Aubin Reviewed-by: Mike Graves <mgraves@redhat.com> (cherry picked from commit f5d7fd2)
Change URL for library item list in 7.0.3 spec SUMMARY When retrieving a list of items inside a content library, the URL was malformed due to a double key in the query. Spec 7.0.3 is changed to look like it did in 7.0.2. Fixes ansible-collections#463 ISSUE TYPE Bugfix Pull Request COMPONENT NAME content_library_item_info Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis (cherry picked from commit b757870)
Update docs for network_moid lookup SUMMARY Update documentation block for network_moid lookup to reflect constraint that the network name must be unique across switches in a given datacenter/folder for the lookup to work. See ansible-collections#467 ISSUE TYPE Docs Pull Request COMPONENT NAME plugins.lookup.network_moid Reviewed-by: Ondra Machacek <machacek.ondra@gmail.com> Reviewed-by: Alina Buzachis (cherry picked from commit f9a2752)
Signed-off-by: Alina Buzachis <abuzachis@redhat.com> (cherry picked from commit 39c5353)
|
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 23s |
|
Additionally, should we also backport #516 while we're at it? |
|
516 was added after the 4.0.0 release, does that matter? It's just a readme change so I'm guessing we may as well include it? |
I think it would be a good idea, otherwise I wouldn't have suggested is ;-) But maybe @bardielle or @machacekondra think differently. Personally, I don't think this is a problem. |
fix cloud.common dependency SUMMARY fix the cloud.common dependency in galaxy.yml Reviewed-by: Mario Lenz <m@riolenz.de> Reviewed-by: Alina Buzachis (cherry picked from commit e3d0b15)
Cherry pick all the changes from Release 3.0.1 (ansible-collections#489) Release 3.0.1 Release 3.0.1 Reviewed-by: Mario Lenz m@riolenz.de Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Ondra Machacek <machacek.ondra@gmail.com> Reviewed-by: Alina Buzachis (cherry picked from commit de4b81c)
Signed-off-by: Alina Buzachis <abuzachis@redhat.com> (cherry picked from commit e5b9a4e)
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
SUMMARY Mention vmware.vmware.vcsa_settings in modules (instead of deprecating them in favor of it). ISSUE TYPE Feature Pull Request COMPONENT NAME appliance_access_consolecli appliance_access_dcui appliance_access_shell appliance_access_ssh appliance_networking_dns_domains appliance_networking_dns_servers appliance_ntp appliance_system_time_timezone appliance_timesync ADDITIONAL INFORMATION ansible-collections#502 Reviewed-by: mikemorency
SUMMARY The lookup plugin documentation needs to be updated. Its missing useful examples, inconsistent, and can be vague. These changes should address those issues. ISSUE TYPE Docs Pull Request COMPONENT NAME all lookup plugins (plugins/lookup/*) Reviewed-by: Brian Coca Reviewed-by: mikemorency Reviewed-by: Alina Buzachis
…lections#514) SUMMARY Dear maintainers, As a part of the Consolidating Ansible discussion platforms initiative, this PR adds the communication section template defined by the community to the README. Similar PRs are being raised across all included collections under the ansible-collection org for now. If you have other tags/forum groups related to the collection I didn't spot, please update corresponding lines by suggesting changes to the PR. IMPORTANT: please, consider moving your WG mentioned in README to the forum group, request it using https://docs.ansible.com/ansible/devel/community/communication.html#requesting-a-forum-group and update the README (or let me know) ISSUE TYPE Docs Pull Request COMPONENT NAME README.md Reviewed-by: Danielle Barda
SUMMARY Let's add the newly created forum group to the README. ISSUE TYPE Docs Pull Request COMPONENT NAME README.md ADDITIONAL INFORMATION ansible-collections/vmware.vmware#58 Reviewed-by: mikemorency
mikemorency
force-pushed
the
stable-3-cherry-pick
branch
from
558fc93
to
0bca915
Compare
|
OK, included 516 and removed the breaking change! |
|
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 12m 34s |
|
So why not include the commits using the label? |
Yeah, seems it's broken for some time: https://github.com/ansible-collections/vmware.vmware_rest/actions/workflows/patchback.yml |
machacekondra
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is cherry picking missing commits from main into stable-3 prior to the next 3.X release
ISSUE TYPE
ADDITIONAL INFORMATION
Let me know if this is not how things are normally backported. As far as I can tell, these are commits that the backport-3 label was not applied to (or missed) but should be included in the next 3.x minor release