Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build Ansible Docs workflow #518

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

Trying to fix the Build Ansible Docs CI workflow which fails ATM.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

.github/workflows/docs-push.yml

ADDITIONAL INFORMATION

This and the following comment.

Copy link
Contributor

Copy link
Collaborator

@mikemorency mikemorency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for following up. I completely overlooked this

feel free to merge when ready

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/8bcac0bccc264990870696a3af8bcc62

✔️ build-ansible-collection SUCCESS in 7m 56s
✔️ ansible-galaxy-importer SUCCESS in 4m 25s

Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@mariolenz mariolenz merged commit a9a257f into ansible-collections:main Aug 21, 2024
13 checks passed
@mariolenz mariolenz deleted the 20240820-fix-ci branch August 21, 2024 08:05
@mariolenz
Copy link
Collaborator Author

This fixed the original error, but now there's a new one.

@mikemorency @alinabuzachis This workflow is quite new, it looks like you've introduced it only 3 weeks ago. Do we really need (or at least want) this? In that case, it would be great if you could make it succeed.

If not, should we simply drop it?

@mikemorency
Copy link
Collaborator

mikemorency commented Aug 21, 2024

I got the action to pass, but the github pages link just leads to a 404.
I dont really see any other collection repos with github pages or built RST files. Is this some legacy way of documenting the collections or just a one off quirk?

@mariolenz
Copy link
Collaborator Author

I have no idea 🤷

You've introduced this in #505 and @alinabuzachis approved. Where did you get this workflow from, and why did you add it?

For community.vmware I've dropped the docs some time ago and simply rely on it being part of the Ansible Community Package and the documentation showing up on docs.ansible.com.

Which is also the case for vmware.vmware_rest.

So if neither you nor @alinabuzachis can give a good reason to have this workflow, I repeat my suggestion to drop it ;-)

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 22, 2024
SUMMARY
This workflow fails the CI, while at the same time I don't understand why it's even there. I think we should remove it.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
.github/workflows/docs-push.yml
ADDITIONAL INFORMATION
#518
#511
#505

Reviewed-by: mikemorency
mikemorency pushed a commit to mikemorency/vmware.vmware_rest that referenced this pull request Sep 12, 2024
SUMMARY
This workflow fails the CI, while at the same time I don't understand why it's even there. I think we should remove it.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
.github/workflows/docs-push.yml
ADDITIONAL INFORMATION
ansible-collections#518
ansible-collections#511
ansible-collections#505

Reviewed-by: mikemorency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants