Stop redownloading cni #200
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before only one sha was being downloaded for checking against even if each host required a different cni plugin distribution.
…ly installed This is done by storing the checksum used on the server after installation. This checksum file is then compared to the local checksum file for the requested CNI plugins. If they do not match (hash has changed or version is different), then plugins will be installed or updated.
IamTheFij
force-pushed
the
stop-redownloading-cni
branch
from
681bfc0 to
7179d7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation redownloads CNI plugins every run. This compares the sha first.
This depends on #156. I'll rebase and undraft after that is merged.