Allow to specify which sanity tests to run / skip / enable #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
force-pushed
the
skip
branch
2 times, most recently
from
4c8a42e to
a4a6bce
Compare
webknjaz
reviewed
Feb 20, 2024
webknjaz
reviewed
Feb 20, 2024
|
@felixfontein sorry, I only now noticed this PR. Could you separate refactoring/restructuring, linter adjustments and actual functional changes so they could be accepted/reviewed separately? |
felixfontein
force-pushed
the
skip
branch
2 times, most recently
from
973da73 to
0f8ef12
Compare
This is useful when tests totally fail (skipping tests), or when sanity tests take too long and should be split up into parallel jobs (skipping and explicitly picking tests), or to enable tests that are disabled by default (like deprecation by date expiry).
|
FTR I clicked the "rebase" button on GH UI. |
webknjaz
reviewed
Mar 31, 2024
webknjaz
reviewed
Mar 31, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
|
@felixfontein are you making any more changes here or should I consider merging? |
|
|
|
@webknjaz yes, sorry, I was done here :) Thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a refactor to generate all ansible-test parameters with Python code.
Skipping specific sanity tests is needed when these totally break due to bugs, see for example ansible/ansible#82574. There is no way to ignore the failure fixed by that PR with
ignore.txt.