Skip to content

Make vault_disable_mlock a role parameter defaulted to false #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

nununo
Copy link

@nununo nununo commented Apr 16, 2022

Proposal for implementing issue #287 which I posted earlier today.

@@ -87,6 +87,9 @@ listener "tcp" {
{% include vault_backend_raft with context -%}
{% endif %}

{% if vault_disable_mlock -%}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect if vault_disable_mlock is defined

Copy link
Author

@nununo nununo Sep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my! I believe you're right.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just submitted a correction.

@nununo
Copy link
Author

nununo commented Oct 5, 2022

The template vault_main_configuration.hcl.j2 seems to have changed substantially since I submitted this PR. Hence the conflicts. I'm not sure the problem that this PR intends to solve is gone but, as it is, this PR is no longer relevant so I will close it.

@nununo nununo closed this Oct 5, 2022
@nununo nununo deleted the vault_disable_mlock branch October 5, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants