Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gpg import for rhel servers #185

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Gpg import for rhel servers #185

merged 3 commits into from
Mar 6, 2024

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Mar 5, 2024

Overall Review of Changes:
Section 1.2.1 will fail on new rhel system as gpg key not yet imported

Enhancements:

  • new option by setting to false will check package signature and import key if not imported
    • rhel9cis_force_gpg_key_import:

How has this been tested?:
Manually

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@uk-bolly uk-bolly merged commit 0f58436 into devel Mar 6, 2024
4 checks passed
@uk-bolly uk-bolly deleted the gpg_key branch March 6, 2024 09:10
ipruteanu-sie pushed a commit to siemens/RHEL9-CIS that referenced this pull request Mar 11, 2024
* change logic thanks to @rjacobs1990 see ansible-lockdown#175

* 1.2.1 force gpg import rhel

* fix missing facts

---------

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Pruteanu <ionut.pruteanu@siemens.com>
@uk-bolly uk-bolly mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants