Merge pull request #3 from ansible-middleware/main2

Main2

roles/amq_streams_install/meta/argument_specs.yml

@@ -65,12 +65,12 @@ argument_specs:
                 type: "str"
             amq_streams_install_prereqs_dependencies:
                 default:
-                  - tar
+                    - tar
                 description: "List of system dependencies to instal - not included the required JVM"
                 type: "list"
             amq_streams_install_openjdk_version:
                 default: "17"
-                description: "Specify Java version requirement - if set, it will trigger the installation of the associared OpenJDK package on the target system."
+                description: "Java version - if set, triggers the installation of appropriate openjdk on the target system."
                 type: "str"
             amq_streams_install_home:
                 default: "{{ amq_streams_install_install_dir }}/kafka_{{ amq_streams_install_version }}/"
@@ -116,11 +116,11 @@ argument_specs:
                 description: "Max number of client connexions to Zookeeper"
                 type: "str"
             amq_streams_install_broker_admin_enable_server:
-                default: False
+                default: false
                 description: "Set tp true to enable admin of the Zookeeper server"
                 str: "bool"
             amq_streams_install_broker_enabled:
-                default: True
+                default: true
                 description: "Set to true if the broker should be integrated into systemd and started as a system service"
                 type: "bool"
             amq_streams_install_broker_server_start:

roles/amq_streams_install/tasks/broker.yml

@@ -6,7 +6,7 @@
     owner: "{{ amq_streams_install_broker_user | default(omit) }}"
     group: "{{ amq_streams_install_broker_group | default(omit) }}"
     mode: 0755
-  changed_when: False   # TODO: find a better way to deal with that
+  changed_when: false   # TODO: find a better way to deal with that
 
 - name: "Set server_id for {{ amq_streams_install.broker.service_name }} service."
   ansible.builtin.set_fact:
@@ -25,7 +25,7 @@
 - name: "Start Broker as a systemd service."
   ansible.builtin.include_tasks: start_server.yml
   vars:
-    server_name:  "{{ amq_streams_install.broker.service_name }}"
+    server_name: "{{ amq_streams_install.broker.service_name }}"
     server_start: "{{ amq_streams_install.broker.server_start }}"
     server_config: "{{ amq_streams_install.broker.config.dest }}"
     server_config_template: "{{ amq_streams_install.broker.config.template }}"

roles/amq_streams_install/tasks/download.yml

@@ -7,7 +7,7 @@
       - amq_streams_install.archive.download_dir is defined
       - amq_streams_install.archive.install_dir is defined
       - amq_streams_install.archive.file is defined
-    quiet: True
+    quiet: true
 
 - name: "Determine current working directory to set as download target - if not specified."
   ansible.builtin.set_fact:
@@ -28,7 +28,7 @@
       - download_dir.stat is defined
       - download_dir.stat.exists is defined
       - download_dir.stat.exists
-    quiet: True
+    quiet: true
 
 - name: "Load metadata on download target file: {{ amq_streams_install_path_to_archive_file }}"
   ansible.builtin.stat:

roles/amq_streams_install/tasks/start_server.yml

@@ -4,7 +4,7 @@
     that:
       - server_name is defined
       - server_config is defined
-    quiet: True
+    quiet: true
 
 - name: "Ensure {{ server_name }} configuration is deployed."
   ansible.builtin.template:
@@ -23,7 +23,7 @@
     group: "{{ server_group }}"
     recurse: yes
     state: directory
-  changed_when: False  # tofix
+  changed_when: false  # tofix
   when:
     - server_log_dir is defined
     - server_user is defined