Skip to content

Commit

Permalink
Drop support for Ansible 2.12 and 2.13 (#380)
Browse files Browse the repository at this point in the history
- ansible-core 2.12 and 2.13 reached EOL
- AAP versions (2.1/2.2) using ansible-core 2.12/2.13 also reached EOL

Reference:
- https://access.redhat.com/support/policy/updates/ansible-automation-platform
- https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html
  • Loading branch information
ssbarnea authored May 21, 2024
1 parent b9dc366 commit e3551f2
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .config/requirements.in
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html
ansible-core>=2.12
ansible-core>=2.14
packaging
PyYAML
subprocess-tee>=0.4.1
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/tox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ jobs:
lint
docs
pkg
py39-ansible212
py39-ansible213
py39-ansible214
py39-ansible215
py310-ansible215
Expand Down Expand Up @@ -139,7 +137,7 @@ jobs:

- name: Check for expected number of coverage.xml reports
run: |
JOBS_PRODUCING_COVERAGE=14
JOBS_PRODUCING_COVERAGE=12
if [ "$(find . -name coverage.xml | wc -l | bc)" -ne "${JOBS_PRODUCING_COVERAGE}" ]; then
echo "::error::Number of coverage.xml files was not the expected one (${JOBS_PRODUCING_COVERAGE}): $(find . -name coverage.xml |xargs echo)"
exit 1
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
[![codecov.io](https://codecov.io/github/ansible/ansible-compat/coverage.svg?branch=main)](https://codecov.io/github/ansible/ansible-compat?branch=main)

A python package contains functions that facilitate working with various
versions of Ansible 2.12 and newer.
versions of Ansible 2.14 and newer.

Documentation is available at
[ansible-compat.readthedocs.io](https://ansible-compat.readthedocs.io/).
2 changes: 1 addition & 1 deletion src/ansible_compat/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
]

# Minimal version of Ansible we support for runtime
ANSIBLE_MIN_VERSION = "2.12"
ANSIBLE_MIN_VERSION = "2.14"

# Based on https://docs.ansible.com/ansible/latest/reference_appendices/config.html
ANSIBLE_DEFAULT_ROLES_PATH = (
Expand Down
16 changes: 3 additions & 13 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,10 @@ envlist =
docs
py
py-devel
py39-ansible212
py39-ansible213
py39-ansible214
py39-ansible215
py310-ansible212
py310-ansible213
py310-ansible214
py310-ansible215
py311-ansible212
py311-ansible213
py311-ansible214
py311-ansible215
py312-ansible216
Expand All @@ -30,15 +24,11 @@ requires =
description =
Run the tests
devel: ansible devel branch
ansible212: ansible-core 2.12
ansible213: ansible-core 2.13
ansible214: ansible-core 2.14
ansible215: ansible-core 2.15
ansible216: ansible-core 2.16

deps =
ansible212: ansible-core>=2.12,<2.13
ansible213: ansible-core>=2.13,<2.14
ansible214: ansible-core>=2.14,<2.15
ansible215: ansible-core>=2.15,<2.16
ansible216: ansible-core>=2.16,<2.17
Expand All @@ -61,7 +51,7 @@ commands =
# pytest users to run coverage when they just want to run a single test with `pytest -k test`
coverage run -m pytest {posargs:}
# needed for upload to codecov.io
{py,py39,py310,py311,py312,py313}: sh -c "coverage combine -a -q --data-file={envdir}/.coverage {envdir}/.coverage.* && coverage xml --data-file={envdir}/.coverage -o {envdir}/coverage.xml --ignore-errors --fail-under=0 && COVERAGE_FILE={envdir}/.coverage coverage lcov --fail-under=0 --ignore-errors -q && COVERAGE_FILE={envdir}/.coverage coverage report --fail-under=0 --ignore-errors"
{py,py39,py310,py311,py312,py313}: sh -c "coverage combine -q --data-file={envdir}/.coverage {envdir}/.coverage.* && coverage xml --data-file={envdir}/.coverage -o {envdir}/coverage.xml --ignore-errors --fail-under=0 && COVERAGE_FILE={envdir}/.coverage coverage lcov --fail-under=0 --ignore-errors -q && COVERAGE_FILE={envdir}/.coverage coverage report --fail-under=0 --ignore-errors"
# lcov needed for vscode integration due to https://github.com/ryanluker/vscode-coverage-gutters/issues/403
# We fail if files are modified at the end
git diff --exit-code
Expand Down Expand Up @@ -153,10 +143,10 @@ commands =
pip uninstall -y ansible-compat

[testenv:py]
description = Run the tests with {basepython} ansible-core 2.12+
description = Run the tests with {basepython} ansible-core 2.14+
deps =
{[testenv]deps}
ansible-core>=2.12
ansible-core>=2.14

[testenv:rpm]
description = Use packit to build RPM (requires RPM based Linux distro)
Expand Down

0 comments on commit e3551f2

Please sign in to comment.