Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collection installation with custom project_dir #343

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Fix collection installation with custom project_dir #343

merged 1 commit into from
Dec 29, 2023

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Dec 27, 2023 •
edited
Loading

  • fix bug that disregarded passed project_dir and used cwd instead
  • updated test dependencies
  • fixed codecov config

@ssbarnea ssbarnea requested a review from a team as a code owner December 27, 2023 10:53
@ssbarnea ssbarnea requested review from priyamsahoo and shatakshiiii and removed request for a team December 27, 2023 10:53
@ssbarnea ssbarnea changed the title Update test deps Fix collection installation with custom project_dir Dec 29, 2023
@ssbarnea
Fix collection installation with custom project_dir
482ee3b 
- fix bug that disregarded passed project_dir and used cwd instead
- updated test dependencies
- fixed codecov config
@ssbarnea ssbarnea added bug Something isn't working and removed skip-changelog labels Dec 29, 2023
@ssbarnea ssbarnea merged commit 2726e6b into main Dec 29, 2023
29 checks passed
@ssbarnea ssbarnea deleted the chore/deps3 branch December 29, 2023 14:59
This was referenced Jan 3, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatakshiiii shatakshiiii shatakshiiii approved these changes

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug Something isn't working
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssbarnea @shatakshiiii