Support ansible 2.18, drop 2.14/2.15 and py39 #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
fix/ruff-preview
branch
from
898054d to
ac7bc03
Compare
ssbarnea
force-pushed
the
fix/ruff-preview
branch
from
ac7bc03 to
95f4f2a
Compare
ssbarnea
changed the title
ssbarnea
changed the title
alisonlhart
approved these changes
Jan 7, 2025
Qalthos
reviewed
Jan 7, 2025
Comment on lines
+350
to
+358
| # noinspection PyProtectedMember | ||
| # pylint: disable=protected-access | ||
| col_path += self.config.collections_paths | ||
| col_path += os.path.dirname( # noqa: PTH120 | ||
| os.environ.get(ansible_collections_path(), "."), | ||
| ).split(":") | ||
| _AnsibleCollectionFinder( # noqa: SLF001 | ||
| paths=col_path, | ||
| )._install() # pylint: disable=protected-access |
There was a problem hiding this comment.
Not sure if I'm missing something, but this seems to be retaining the < 2.15.0.dev0 path?
There was a problem hiding this comment.
Oops, read this after I merged it. Next time add -1. I am making a patch now. Second question would be.... why testing did not find any issues.
There was a problem hiding this comment.
Please review #444
And, thanks for spotting it!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html