-
Notifications
You must be signed in to change notification settings - Fork 40
Scaffold action plugin through add subcommand #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4fe76c
to
6477c4d
Compare
6477c4d
to
414d576
Compare
abhikdps
approved these changes
Jan 3, 2025
7155cdc
to
6100e07
Compare
cidrblock
requested changes
Jan 6, 2025
src/ansible_creator/resources/collection_project/plugins/action/hello_world.py.j2
Outdated
Show resolved
Hide resolved
src/ansible_creator/resources/collection_project/plugins/modules/hello_world.py.j2
Show resolved
Hide resolved
db33d12
to
c1e54da
Compare
c1e54da
to
eafe561
Compare
3179e95
to
7135b33
Compare
71144fc
to
423bac0
Compare
… not a valid value for dictionary value quit exit
09ff27a
to
1b93876
Compare
cidrblock
previously requested changes
Jan 13, 2025
abhikdps
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
cidrblock
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds support to scaffold
action
plugins in an existing ansible collection using add subcommand.Additionally scaffolds a module file with plugin
DOCUMENTATION
andEXAMPLES
for corresponding action plugin.Also, it creates a sample
hello_world.py
action plugin template when initializing a collection project using init subcommand.CLI usage:
Related JIRA: https://issues.redhat.com/browse/AAP-36202
Supporting docs for action plugin: