[WIP] Add rules on moving content to collections outside of Ansible #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
temporarily deployed
to
github-bot
GitHub Actions
Inactive
ansible-documentation-bot
bot
added
the
sc_approval
mariolenz
reviewed
Oct 7, 2024
docs/docsite/rst/community/collection_contributors/collection_requirements.rst
Show resolved
Hide resolved
gotmax23
reviewed
Oct 16, 2024
docs/docsite/rst/community/collection_contributors/collection_requirements.rst
Outdated
Show resolved
Hide resolved
|
|
||
| For the community "catch all" collections, we have slightly different rules. We allow to move content out of community.general and community.network to other collections outside of Ansible under the following conditions: | ||
|
|
||
| 1. The new collection is appropriately licensed and does not require a CLA to contribute. |
There was a problem hiding this comment.
Instead of "does not require a CLA to contribute," can we say "follows the Contributor License Agreements policy" and make that a link to the the "Contributor License Agreements" section? There's more detail there about what constitutes a CLA and also that we allow the DCO.
docs/docsite/rst/community/collection_contributors/collection_requirements.rst
Outdated
Show resolved
Hide resolved
docs/docsite/rst/community/collection_contributors/collection_requirements.rst
Outdated
Show resolved
Hide resolved
docs/docsite/rst/community/collection_contributors/collection_requirements.rst
Outdated
Show resolved
Hide resolved
docs/docsite/rst/community/collection_contributors/collection_requirements.rst
Show resolved
Hide resolved
|
I did some grammar policing, but this looks good to me, and I agree with the policy here. Thanks! |
Co-authored-by: Maxwell G <maxwell@gtmx.me>
felixfontein
temporarily deployed
to
github-bot
GitHub Actions
Inactive
felixfontein
temporarily deployed
to
github-bot
GitHub Actions
Inactive
felixfontein
temporarily deployed
to
github-bot
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the proposal of https://forum.ansible.com/t/5738/2.
I was not able to find a rule in the requirements that if content is moved out from collections in Ansible, that the resulting collection also has to be part of Ansible. Since the original discussions are more than two years old (ansible-community/community-topics#167), I'm missing the context... If someone remembers (or finds where this is mentioned in the requirements or elsewhere in the docs), please mention it here :)