Address ruff PTH120

pyproject.toml

@@ -301,7 +301,6 @@ ignore = [
   'PT022', # [*] No teardown in fixture `cmd_in_tty`, use `return` instead of `yield`
   'PTH109', # `os.getcwd()` should be replaced by `Path.cwd()`
   'PTH118', # `os.path.join()` should be replaced by `Path` with `/` operator
-  'PTH120', # `os.path.dirname()` should be replaced by `Path.parent`
   'RET505', # Unnecessary `else` after `return` statement
   'RUF005', # [*] Consider `[self._name, *shlex.split(self._interaction.action.match.groupdict()["params"] or "")]` instead of concatenation
   'RUF012', # Mutable class attributes should be annotated with `typing.ClassVar`

src/ansible_navigator/actions/collections.py

@@ -415,7 +415,7 @@
         }
 
         if isinstance(self._args.playbook, str):
-            playbook_dir = os.path.dirname(self._args.playbook)
+            playbook_dir = f"{Path(self._args.playbook).parent}"
         else:
             playbook_dir = os.getcwd()
 
@@ -566,7 +566,7 @@
                     "path"
                 ].startswith(self._adjacent_collection_dir):
                     collection["__type"] = "bind_mount"
-                elif collection["path"].startswith(os.path.dirname(self._adjacent_collection_dir)):
+                elif collection["path"].startswith(f"{Path(self._adjacent_collection_dir).parent}"):
                     collection["__type"] = "bind_mount"
                     error = (
                         f"{collection['known_as']} was mounted and catalogued in the"

src/ansible_navigator/actions/doc.py

@@ -8,6 +8,7 @@
 import shlex
 import shutil
 
+from pathlib import Path
 from typing import TYPE_CHECKING
 from typing import Any
 
@@ -177,7 +178,7 @@
 
         if self._args.mode == "interactive":
             if isinstance(self._args.playbook, str):
-                playbook_dir = os.path.dirname(self._args.playbook)
+                playbook_dir = f"{Path(self._args.playbook).parent}"
             else:
                 playbook_dir = os.getcwd()
             kwargs.update({"host_cwd": playbook_dir})

src/ansible_navigator/actions/run.py

@@ -886,7 +886,7 @@ def write_artifact(self, filename: str | None = None) -> None:
                 playbook = next(k["playbook"] for k in self._plays.value)
             filename = filename or self._args.playbook_artifact_save_as
             filename = filename.format(
-                playbook_dir=os.path.dirname(playbook),
+                playbook_dir=Path(playbook).parent,
                 playbook_name=Path(playbook).stem,
                 playbook_status=status,
                 time_stamp=now_iso(self._args.time_zone),
@@ -896,7 +896,7 @@ def write_artifact(self, filename: str | None = None) -> None:
             self._logger.debug("Resolved artifact file name set to %s", filename)
 
             try:
-                Path(os.path.dirname(filename)).mkdir(parents=True, exist_ok=True)
+                Path(Path(filename).parent).mkdir(parents=True, exist_ok=True)
                 artifact = {
                     "version": "2.0.0",
                     "plays": self._plays.value,

src/ansible_navigator/configuration_subsystem/navigator_post_processor.py

@@ -738,7 +738,7 @@ def log_file(entry: SettingsEntry, config: ApplicationConfiguration) -> PostProc
         exit_messages: list[ExitMessage] = []
         entry.value.current = str(expand_path(entry.value.current))
         try:
-            Path(os.path.dirname(entry.value.current)).mkdir(parents=True, exist_ok=True)
+            Path(Path(entry.value.current).parent).mkdir(parents=True, exist_ok=True)
             Path(entry.value.current).touch()
         except (OSError, FileNotFoundError) as exc:
             exit_msgs = [

src/ansible_navigator/initialization.py

@@ -107,17 +107,17 @@
     messages.append(LogMessage(level=logging.DEBUG, message=message))
 
     path_errors = []
-    doc_cache_dir = os.path.dirname(collection_doc_cache_path)
+    doc_cache_dir = Path(collection_doc_cache_path).parent
     try:
-        Path(doc_cache_dir).mkdir(parents=True, exist_ok=True)
+        doc_cache_dir.mkdir(parents=True, exist_ok=True)
     except OSError as exc:
-        path_errors.append(f"Problem making directory: {doc_cache_dir}")
+        path_errors.append(f"Problem making directory: {doc_cache_dir!s}")
         path_errors.append(f"Error was: {exc!s}")
 
-    if not os.access(os.path.dirname(collection_doc_cache_path), os.W_OK):
+    if not os.access(Path(collection_doc_cache_path).parent, os.W_OK):
         path_errors.append("Directory not writable")
 
-    if not os.access(os.path.dirname(collection_doc_cache_path), os.R_OK):
+    if not os.access(Path(collection_doc_cache_path).parent, os.R_OK):
         path_errors.append("Directory not readable")
 
     if path_errors: