Skip to content

Satisfy MyPy with Credential interface #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chrismeyersfsu
Copy link
Member

No description provided.

@chrismeyersfsu chrismeyersfsu force-pushed the AAP-35749-move-inject-credential-interface branch from 7e63b28 to f1fe302 Compare November 22, 2024 14:18
@webknjaz webknjaz changed the title Satisfy mypi with Credential interface Satisfy MyPy with Credential interface Nov 22, 2024
@webknjaz
Copy link
Member

@chrismeyersfsu why did you think this is needed, though?

@chrismeyersfsu
Copy link
Member Author

Not needed.

I think my .pre-commit-config.yaml was pointed at an "old" interface version git+https://github.com/ansible/awx_plugins.interfaces.git@ad4a965 That version didn't have the class Credential. Adding Credential to the .pyi interfaces didn't solve my problem, pointing to a version of awx_plugins.interfaces with class Credential is what actually solved my problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants