fix(AAP-29089): change organization field to be required in RBAC managed resources #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated the test suite in https://github.com/ansible/eda-qa/pull/419 I did a test run locally and everything was passing, but we want to do a run in the gh pipelines too. |
|
e2e tests job run: https://github.com/ansible/eda-server/actions/runs/10403641006 |
Dostonbek1
force-pushed
the
make-org-required
branch
from
3f39d5f to
30b109b
Compare
zkayyali812
approved these changes
Aug 15, 2024
Dostonbek1
force-pushed
the
make-org-required
branch
2 times, most recently
from
95b8e6e to
6bad484
Compare
hsong-rh
approved these changes
Aug 16, 2024
Dostonbek1
added
run-ui-e2e
Dostonbek1
force-pushed
the
make-org-required
branch
from
6bad484 to
e9f3bc9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to make organization field a required field for all RBAC managed resources.
NOTE: This is a breaking change for the UI; we should merge this PR in sync with the one from the UI folks. cc @lgalis
JIRA: AAP-29089