chore: remove old event stream from codebase #1008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkanoor
force-pushed
the
remove_event_stream
branch
5 times, most recently
from
9bbffc0 to
5b65947
Compare
mkanoor
added
run-e2e
run-ui-e2e
|
@mkanoor Do you have a PR in plan for updating the e2e tests for these changes? |
hsong-rh
reviewed
Aug 16, 2024
mkanoor
force-pushed
the
remove_event_stream
branch
2 times, most recently
from
b761e11 to
1812108
Compare
hsong-rh
previously approved these changes
Aug 16, 2024
|
@Dostonbek1 I have generated a new API client in this PR https://github.com/ansible/eda-qa/pull/420 |
|
@Dostonbek1 e2e tests on demand are passing with https://github.com/ansible/eda-qa/pull/420 https://github.com/ansible/eda-server/actions/runs/10427089812 |
|
@mkanoor sanity check for e2e run: https://github.com/ansible/eda-server/actions/runs/10428558625 |
mkanoor
force-pushed
the
remove_event_stream
branch
3 times, most recently
from
a97c3d3 to
faa628c
Compare
Alex-Izquierdo
approved these changes
Aug 21, 2024
hsong-rh
approved these changes
Aug 21, 2024
https://issues.redhat.com/browse/AAP-27632 Remove the old EventStream from fanout
mkanoor
force-pushed
the
remove_event_stream
branch
from
faa628c to
92bceb9
Compare
|
|
Closing this PR as the changes have landed as a part of #1011. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/AAP-27632
Remove the old EventStream from fanout