Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (AAP-29642) - Fix to save encrypted string in credentials #1021

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: (AAP-29642) - Fix to save encrypted string in credentials #1021

merged 1 commit into from
Aug 26, 2024

Conversation

hsong-rh
Copy link
Contributor

@hsong-rh hsong-rh requested a review from a team as a code owner August 22, 2024 13:09
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 22, 2024
View reviewed changes
tests/integration/api/test_eda_credential.py
"""

DUMMY_SSH_KEY = """
-----BEGIN OPENSSH PRIVATE KEY-----

Check failure

Code scanning / SonarCloud

SSH private keys should not be disclosed

<!--SONAR_ISSUE_KEY:AZF6NUkvVpQLYr2VY7Yp-->Make sure this SSH private key gets revoked, changed, and removed from the code. <p>See more on <a href="https://sonarcloud.io/project/issues?id=ansible_eda-server&issues=AZF6NUkvVpQLYr2VY7Yp&open=AZF6NUkvVpQLYr2VY7Yp&pullRequest=1021">SonarCloud</a></p>
@hsong-rh hsong-rh force-pushed the aap-29642 branch 2 times, most recently from 5bf28c0 to b101f62 Compare August 22, 2024 15:51
@hsong-rh hsong-rh requested a review from mkanoor August 26, 2024 13:14
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@hsong-rh hsong-rh merged commit 8e06d75 into ansible:main Aug 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkayyali812 zkayyali812 zkayyali812 approved these changes

@mkanoor mkanoor mkanoor approved these changes

Assignees
No one assigned
Labels
run-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsong-rh @mkanoor @zkayyali812