-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support PG Notify for event streams using credentials #1176
Conversation
0d6fc17
to
28ea7af
Compare
c429d87
to
3fa5f37
Compare
f77b4af
to
bda4178
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
732ef26
to
bd60022
Compare
0b9cc22
to
a721d08
Compare
The api-e2e-tests work but the api-e2e-multinode-tests fails, seems like a flaky test unrelated to changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, @mkanoor can you also add some documentation that explains how this can be tested?
In order to test the mTLS for postgres you need to generate certificates for Postgres Server and for our EDA Server and Activation. You can use step-ca to generate certs, follow the instructions to install step-ca , once step-ca is installed and running locally you can generate the certs For docker running on Mac
Run docker-compose with ./tools/docker/docker-compose-mac-pg-mtls.yml Create an Event Stream with Basic Auth Credentials |
a8bd3c6
to
dde20b3
Compare
Create a Postgres credential that can store certificates and keys or userid/password at server startup and attach it to Activations that use EventStream. This allows us to test mTLS for Postgres, a sample pg_hba file is attached to this PR. To test this you need to create certificates and keys for * Postgres Server called (server.crt and server.key) * EDA Server called (client.crt and client.key) * You also need to create the CA certificate These files have to be present in tools/docker/postgres_ssl_config/certs The docker-compose file tools/docker/docker-compose-mac-pg-mtls.yml can be used to test mTLS The docker-compose file tools/docker/docker-compose-mac.yml can be used to test userid/password auth
dde20b3
to
50a86fe
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tested it because it would require some time as I have to replicate the env for linux systems (only mac provided) but so far, LGTM.
We need to revisit how we handle the database and pgnotify config as we were discussing.
Create a Postgres credential that can store certificates and keys or userid/password at server startup and attach it to Activations that use EventStream.
This allows us to test mTLS for Postgres, a sample pg_hba file is attached to this PR.
To test this you need to create certificates and keys for
These files have to be present in
tools/docker/postgres_ssl_config/certs
The docker-compose file tools/docker/docker-compose-mac-pg-mtls.yml can be used to test mTLS
The docker-compose file tools/docker/docker-compose-mac.yml can be used to test userid/password auth
https://issues.redhat.com/browse/AAP-38315