[AAP-37476]: Validate DE Urls #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkayyali812
force-pushed
the
zk/fix-de/scheme
branch
2 times, most recently
from
8c2e523 to
3320cd0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1188 +/- ##
==========================================
+ Coverage 93.34% 93.35% +0.01%
==========================================
Files 261 261
Lines 14875 14908 +33
==========================================
+ Hits 13885 13918 +33
Misses 990 990
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zkayyali812
force-pushed
the
zk/fix-de/scheme
branch
from
bed05a8 to
a14c1ed
Compare
Alex-Izquierdo
previously approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Looking at the spec I'm not sure if we should support as well sha512. Anycase LGTM
|
@Alex-Izquierdo great note! I just pushed a commit to ensure this case is covered as well. Better sooner than later |
Alex-Izquierdo
approved these changes
Jan 16, 2025
|
ttuffin
approved these changes
Jan 17, 2025
kaiokmo
pushed a commit
to kaiokmo/event-driven-ansible
that referenced
this pull request
Jan 20, 2025
The 'image_url' field is incorrect in the decision_enrivonment tests and it does not correspond to valid OCI image/tag/naming standards. Proper validation of the image_url field was introduced here [1], and the tests of the collection must reflect it. [1] ansible/eda-server#1188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation to DE image URLs.
Upon checking this issue out, we only had validation on registry credentials, and no validation on DE's.
This PR ensures we have the same validation on both registry credential URLs and Decision environments.
This PR also updates the validation to ensure that if a DE URL with digest is specified, that this is a valid specification.