Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAP-40292] Add log tracking id for logging messages #1217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hsong-rh
Copy link
Contributor

@hsong-rh hsong-rh commented Feb 24, 2025

Add the log_tracking_id field to the Activation record. it's in UUID format and will display in activation workers' and WebSocket workers's log messages.

@hsong-rh hsong-rh requested a review from a team as a code owner February 24, 2025 17:20
@hsong-rh hsong-rh marked this pull request as draft February 24, 2025 17:21
@hsong-rh hsong-rh changed the title [AAP-40292] Add request id to logging messages [AAP-40292] Add log tracking id for logging messages Feb 25, 2025
@hsong-rh hsong-rh marked this pull request as ready for review February 25, 2025 16:23
@hsong-rh hsong-rh force-pushed the add_request_id branch 3 times, most recently from 5923ab5 to ffe9d86 Compare February 25, 2025 17:01
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.65%. Comparing base (960e8b5) to head (339149a).

@@            Coverage Diff             @@
##             main    #1217      +/-   ##
==========================================
+ Coverage   93.62%   93.65%   +0.03%     
==========================================
  Files         277      280       +3     
  Lines       15679    15760      +81     
==========================================
+ Hits        14679    14760      +81     
  Misses       1000     1000              
Flag Coverage Δ
unit-int-tests-3.11 93.59% <100.00%> (+0.03%) ⬆️
unit-int-tests-3.12 93.65% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/aap_eda/api/serializers/activation.py 96.04% <100.00%> (+0.01%) ⬆️
...core/migrations/0059_activation_log_tracking_id.py 100.00% <100.00%> (ø)
src/aap_eda/core/models/activation.py 100.00% <100.00%> (ø)
.../aap_eda/services/activation/activation_manager.py 64.21% <100.00%> (+0.92%) ⬆️
src/aap_eda/services/activation/engine/common.py 81.29% <100.00%> (+0.12%) ⬆️
src/aap_eda/services/activation/engine/podman.py 94.61% <100.00%> (+0.02%) ⬆️
src/aap_eda/settings/default.py 89.16% <ø> (ø)
src/aap_eda/utils/log_tracking_id_filter.py 100.00% <100.00%> (ø)
src/aap_eda/wsapi/consumers.py 92.50% <100.00%> (+0.21%) ⬆️
...egration/services/activation/engine/test_podman.py 98.71% <100.00%> (ø)
... and 2 more
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hsong-rh hsong-rh force-pushed the add_request_id branch 4 times, most recently from b3010aa to e31974a Compare February 26, 2025 18:42
ttuffin
ttuffin previously approved these changes Feb 27, 2025
zkayyali812
zkayyali812 previously approved these changes Feb 27, 2025
@hsong-rh hsong-rh dismissed stale reviews from zkayyali812 and ttuffin via 339149a March 6, 2025 18:30
Copy link

sonarqubecloud bot commented Mar 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants