-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add more versions to startup log #1225
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Alex <aizquier@redhat.com>
38b64a4
to
a615843
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1225 +/- ##
=======================================
Coverage 93.62% 93.62%
=======================================
Files 277 277
Lines 15679 15685 +6
=======================================
+ Hits 14679 14685 +6
Misses 1000 1000
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, except for one minor nitpick below.
|
Follow up #1216 by adding some package version that I think are relevant.
Refactor
get_eda_version
toget_package_version
for a more general purpose helper.Update tests accordingly