Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more versions to startup log #1225

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Alex-Izquierdo
Copy link
Collaborator

@Alex-Izquierdo Alex-Izquierdo commented Feb 27, 2025

Follow up #1216 by adding some package version that I think are relevant.
Refactor get_eda_version to get_package_version for a more general purpose helper.
Update tests accordingly

@Alex-Izquierdo Alex-Izquierdo requested a review from a team as a code owner February 27, 2025 13:11
ttuffin
ttuffin previously approved these changes Feb 27, 2025
Signed-off-by: Alex <aizquier@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.62%. Comparing base (9cad007) to head (f05f510).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main    #1225   +/-   ##
=======================================
  Coverage   93.62%   93.62%           
=======================================
  Files         277      277           
  Lines       15679    15685    +6     
=======================================
+ Hits        14679    14685    +6     
  Misses       1000     1000           
Flag Coverage Δ
unit-int-tests-3.11 93.56% <100.00%> (+<0.01%) ⬆️
unit-int-tests-3.12 93.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/aap_eda/api/views/config.py 100.00% <100.00%> (ø)
src/aap_eda/settings/default.py 89.16% <ø> (ø)
src/aap_eda/utils/__init__.py 100.00% <100.00%> (ø)
src/aap_eda/utils/logging.py 96.96% <100.00%> (+0.30%) ⬆️
tests/integration/api/test_config.py 100.00% <100.00%> (ø)
tests/unit/test_logging.py 100.00% <100.00%> (ø)
tests/unit/test_utils.py 100.00% <100.00%> (ø)

Copy link
Member

@Dostonbek1 Dostonbek1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, except for one minor nitpick below.

Copy link

sonarqubecloud bot commented Mar 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants