feat: allow for unlimited running activations #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
previously approved these changes
Feb 20, 2024
|
waiting to merge first #675 |
Signed-off-by: Alex <aizquier@redhat.com>
Alex-Izquierdo
force-pushed
the
unlimit-max-activations
branch
from
3dca95e to
e2a1041
Compare
mkanoor
approved these changes
Feb 21, 2024
hsong-rh
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios, like for example an autoscaling cluster of k8s, the user might want to not limit the max running activations. This PR honors the -1 value to disable the limit.