-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated release #691
Automated release #691
Conversation
1fca9bc
to
d1198bb
Compare
d1198bb
to
f397d41
Compare
61e57c2
to
6172102
Compare
In this project we are using |
714b57b
to
0bff8c2
Compare
Task is not available everywhere and is actually hard to install on some older versions of Fedora. We should consider using Makefiles since it is the standard on the rest of the platform. |
0bff8c2
to
ec3575d
Compare
342cafc
to
c3e25b1
Compare
I removed the Makefile and used task instead. |
PYTHON_VERSION: | ||
desc: "Return the required python version for build tools" | ||
cmds: | ||
- cmd: echo "3.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We moved to python3.11
https://github.com/ansible/eda-server/blob/main/pyproject.toml#L28
|
||
build:release: | ||
desc: "builds all the files needed for a release" | ||
cmds: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is missing the build command?
@@ -120,3 +120,25 @@ ban-relative-imports = "parents" | |||
|
|||
[tool.ruff.pydocstyle] | |||
convention = "pep257" | |||
|
|||
[tool.setuptools_scm] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we use poetry for building as it is configured?
https://github.com/ansible/eda-server/blob/main/pyproject.toml#L3
Consumers of eda-server should use the latest build from quay.io |
Adds an automated release process using ansible and github actions.
Run locally with: