Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated release #691

Closed
wants to merge 1 commit into from
Closed

Conversation

benthomasson
Copy link
Collaborator

@benthomasson benthomasson commented Feb 22, 2024

Adds an automated release process using ansible and github actions.

Run locally with:

ansible-playbook tools/ansible/release.yml -i localhost -e github_token=${GH_TOKEN}

@benthomasson benthomasson force-pushed the automated_release branch 2 times, most recently from 1fca9bc to d1198bb Compare February 26, 2024 16:06
@benthomasson benthomasson marked this pull request as ready for review February 26, 2024 16:15
@benthomasson benthomasson requested a review from a team as a code owner February 26, 2024 16:15
@benthomasson benthomasson force-pushed the automated_release branch 2 times, most recently from 61e57c2 to 6172102 Compare March 4, 2024 14:18
Dostonbek1
Dostonbek1 previously approved these changes Mar 4, 2024
Dostonbek1
Dostonbek1 previously approved these changes Mar 4, 2024
@Alex-Izquierdo
Copy link
Collaborator

In this project we are using task I think there is no need to duplicate tools adding a makefile.
https://github.com/ansible/eda-server/blob/main/Taskfile.dist.yaml

@benthomasson
Copy link
Collaborator Author

benthomasson commented Mar 6, 2024

In this project we are using task I think there is no need to duplicate tools adding a makefile. https://github.com/ansible/eda-server/blob/main/Taskfile.dist.yaml

Task is not available everywhere and is actually hard to install on some older versions of Fedora. We should consider using Makefiles since it is the standard on the rest of the platform.

@benthomasson
Copy link
Collaborator Author

I removed the Makefile and used task instead.

PYTHON_VERSION:
desc: "Return the required python version for build tools"
cmds:
- cmd: echo "3.9"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


build:release:
desc: "builds all the files needed for a release"
cmds:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is missing the build command?

@@ -120,3 +120,25 @@ ban-relative-imports = "parents"

[tool.ruff.pydocstyle]
convention = "pep257"

[tool.setuptools_scm]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use poetry for building as it is configured?
https://github.com/ansible/eda-server/blob/main/pyproject.toml#L3

@benthomasson
Copy link
Collaborator Author

Consumers of eda-server should use the latest build from quay.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants