-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable v1 root drf browsable and fix staticfiles #945
Conversation
c66ad75
to
40f5c01
Compare
0e3bc73
to
6489d94
Compare
Don't merge this for now, please. I want to sync the required changes in other places like the installer to avoid broken builds. |
28683db
Signed-off-by: Alex <aizquier@redhat.com>
Signed-off-by: Alex <aizquier@redhat.com>
28683db
to
43d598d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the JIRA ticket expected behavior, this PR doesn't seem to consider the following case:
/api/eda should provide version options for the API
Another minor comment, it seems a little redundant to have the hostname before every endpoint listed in v1 root view, e.g. |
It is out of the scope of this PR. As you can see in the description of the jira, only includes the v1/ |
It seems to me a valid point. I think it is due to the way I generate automatically all the links. I was trying to merge this PR in sync with other required changes to avoid breaking build. New changes in the PR would complicate this. Do you agree to merge as it is and later address the host in a later PR? |
Signed-off-by: Alex <aizquier@redhat.com> Co-authored-by: Madhu Kanoor <mkanoor@redhat.com>
Enable the v1 root for DRF browsable and adds the missing collecstatic step.
It requires updates in the installer/operator/ui_image to run the colllecstatic command and serve those static files.
Jira: https://issues.redhat.com/browse/AAP-25508