fix: make redis_prefix static config #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex <aizquier@redhat.com>
Signed-off-by: Alex <aizquier@redhat.com>
bzwei
previously approved these changes
Jun 20, 2024
Signed-off-by: Alex <aizquier@redhat.com>
bzwei
approved these changes
Jun 20, 2024
hsong-rh
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #897
and #926
As per internal discussions, we agreed to make the redis_prefix a static configuration. Using the service_id as the redis_prefix is problematic because the value is obtained from the database after migrations, but we need it during the early initialization of the application. This reverses the expected order of startup dependencies and causes problems with commands that should not require a DB connection, such as "collectstatic". Additionally, a meaningless prefix makes debugging much more difficult.
EDA is the only component following this pattern, with this PR it is in line with other components where the prefix is a static setting.
Internal ref: https://redhat-internal.slack.com/archives/C06S8Q06AB0/p1718889268198969?thread_ts=1717425927.035389&cid=C06S8Q06AB0