Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add router_basename for models with compound words #949

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

bzwei
Copy link
Collaborator

@bzwei bzwei commented Jun 21, 2024

It helps to reverse the url to access the resource

Needed by https://github.com/ansible/django-ansible-base/blob/devel/ansible_base/lib/abstract_models/common.py#L21

AAP-25487: Role user assignment response missing content_object except for Activations

@bzwei bzwei requested a review from a team as a code owner June 21, 2024 16:08
@bzwei bzwei added the run-e2e label Jun 21, 2024
It helps to reverse the url to access the resource

AAP-25487:Role user assignment response missing content_object except for Activations
Copy link
Collaborator

@Alex-Izquierdo Alex-Izquierdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why shouldn't we have this field defined in all our exposed models?

@bzwei
Copy link
Collaborator Author

bzwei commented Jun 24, 2024

Why shouldn't we have this field defined in all our exposed models?

Adding this field to single word models does not change the resulting base name, but yes we can do this to all exposed models.

@bzwei bzwei merged commit adf743e into ansible:main Jun 25, 2024
4 checks passed
jshimkus-rh pushed a commit to jshimkus-rh/eda-server that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants