Skip to content

Commit

Permalink
False positive output in tox linter checks
Browse files Browse the repository at this point in the history
This commit:
- Makes easier to test individually each commit by allowing
to run the GitHub actions on each fork push and pull request.
- Remove the appended path in the ruff tox check that breaks it
to parse recursivelly all the python code.
- Excluding the test and tests folders on the ruff check to make
easier to pass the functional code linter checks

TODO: This should be applied to all the other tox check to make them
show correctly all the linters errors. And once the functional code
is green, to make pass the tests code.

Closes: #145
  • Loading branch information
ccamacho committed Jun 30, 2023
1 parent cc14e31 commit 4b36f6a
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 14 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
name: Run integration tests
on:
push:
branches: ["main"]
pull_request:
branches: ["main"]
# Run the integration tests every 8 hours.
# This will help to identify faster if
# there is a CI failure related to a
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@
name: Run linters
on:
push:
branches: ["main"]
pull_request:
branches: ["main"]
# Run the linters tests every 8 hours.
# This will help to identify faster if
# there is a CI failure related to a
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
name: Run Ansible tests
on:
push:
branches: ["main"]
pull_request:
branches: ["main"]
# Run the unit tests every 8 hours.
# This will help to identify faster if
# there is a CI failure related to a
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,11 @@ requires =

[testenv:ruff]
deps = ruff
commands = ruff check --select ALL --ignore INP001 -q {posargs}/extensions/eda/plugins

commands = ruff check --select ALL --ignore INP001 --extend-exclude test,tests -q {posargs}

[testenv:darglint]
deps = darglint
commands = darglint -s numpy -z full {posargs}/extensions/eda/plugins

commands = darglint -s numpy -z full {posargs}

# If you dont have any event_source or event_filter plugins, remove the corresponding testenv
[testenv:pylint-event-source]
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/tox.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
---
name: Tox
name: Run Tox linters checks
on:
push:
branches: ["main"]
pull_request:
branches: ["main"]
# Run the tox tests every 8 hours.
# This will help to identify faster if
# there is a CI failure related to a
Expand All @@ -21,4 +19,4 @@ jobs:
- name: Move to tox conf file and run tox
run: |
cd .github/workflows
python -m tox -- ../..
python3 -m tox -- ../..

0 comments on commit 4b36f6a

Please sign in to comment.