-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for galaxy operator #2058
Conversation
793eebe
to
a00d81a
Compare
0198a96
to
3305024
Compare
5558e25
to
1efc3ef
Compare
1efc3ef
to
4280d55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changeset looks good.
Idea: I think we might want to think about adding a "configure-signing-services.sh" for the initContainer to use in a future PR to make the operator codebase a bit cleaner.
But a PR for another day.
4280d55
to
5e6de40
Compare
1. Updating Dockerfile to install required directories in /var/lib/pulp/ 2. Adding skopeo dnf dependency for content signing script 3. Adding readyz.py for galaxy-operator ready check 4. Updating MANIFEST.in No-Issue
5e6de40
to
74b72b3
Compare
@himdel @drodowic @jctanner It looks all of the CI issues pertaining to this PR have been fixed. But the Galaxy CI checks are all failing due to an unrelated problem now when building the image:
I see this in other PR's as well for example: I see this change was made recently... but it is already included in this branch, no need to rebase. Any suggestions on this issue? |
It appears that the base image used by CI when building has python3.8.17, and python3.9+ is required.
|
depends-on: ansible/galaxy-operator#17
'No-Issue'