Enable flake8-datetime plugin for ruff #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-4.9
cutwater
removed
backport-4.10
backport-4.9
rochacbruno
reviewed
Oct 25, 2024
| @@ -192,15 +192,16 @@ def main(): | |||
|
|
|||
| # make a unique checkout for this new patch | |||
| branch_checkout = os.path.join(workdir, f'galaxy_ng.{cfg.branch}') | |||
| ts = datetime.datetime.now().isoformat().split('.')[0].replace('-', '_').replace(':', '_') | |||
| ts = datetime.datetime.now().strftime("%Y_%m_%dT%H_%M_%S") # noqa: DTZ005 | |||
There was a problem hiding this comment.
There is also this option
f"{datetime.now():%Y_%m_%dT%H_%M_%S}"
'2024_10_25T13_48_28'
rochacbruno
approved these changes
Oct 25, 2024
But add `noqa` for existing code, since fixing naive to aware datetime may cause bugs.
cutwater
force-pushed
the
feature/ruff/flake8-datetime
branch
from
7d643d4 to
514fe33
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But add
noqafor existing code, since fixing naive to aware datetime may cause bugs.