-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init django-flags #2374
Init django-flags #2374
Conversation
galaxy_ng/app/settings.py
Outdated
TEMPLATES = [ | ||
{ | ||
'BACKEND': 'django.template.backends.django.DjangoTemplates', | ||
'DIRS': [], | ||
'APP_DIRS': True, | ||
'OPTIONS': { | ||
'context_processors': [ | ||
'django.template.context_processors.request', | ||
], | ||
}, | ||
}, | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already by pulpcore, it we override we are going to break the browsable API I guess
In the case we need to manipulate the setting coming from pulpcore we will need to do in the dynaconf_hooks.py
which will run after data is loaded from pulpcore.
For now I think this can be removed.
Quality Gate passedIssues Measures |
Backport to stable-4.10: 💚 backport PR created✅ Backport PR branch: Backported as #2383 🤖 @patchback |
* init django-flags * fix TemplateDoesNotExist * remove TEMPLATES (cherry picked from commit f4faf42)
Issue: AAP-35418
Add django-flags dependancy to Hub component.
verifications:
MY_FLAG
toFLAGS
ingalaxy_ng/app/settings.py
(django-flags in EDA: ansible/eda-server#1135)