-
Notifications
You must be signed in to change notification settings - Fork 89
Reference #883: env timeout open k8s logstream #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference #883: env timeout open k8s logstream #1154
Conversation
|
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## devel #1154 +/- ##
==========================================
+ Coverage 40.84% 41.48% +0.64%
==========================================
Files 45 48 +3
Lines 9279 9875 +596
==========================================
+ Hits 3790 4097 +307
- Misses 5198 5487 +289
Partials 291 291
... and 7 files with indirect coverage changes
🚀 New features to boost your workflow:
|
thank you for the PR, @aeter! @AaronH88, @thom-at-redhat, @fosterseth - besides the small linting issues to fix, do we need anything else for this PR? |
bb0b10f
to
89a2cf7
Compare
Sorry for the delay in replying, This PR looks really good. I just have a request for a bit more defensive programming and it should be good to merge 😄 |
Signed-off-by: Adrian Nackov <adrian.nackov@mail.schwarz>
89a2cf7
to
4a81a46
Compare
|
Thanks! Updated per review, added more unit tests (for "-1", "0") at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks so much for the PR
References #883
Adds env variable to configure
open logstream timeout
.Please note: when writing this PR: not sure where/how to document the env variable (other than in the code), so users can find it.
Testing: