Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ":" as acceptable char for node ID #1242

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

matoval
Copy link
Collaborator

@matoval matoval commented Dec 12, 2024

Add ":" as acceptable char for node ID and add test

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.64%. Comparing base (ad9c4eb) to head (90726b7).
Report is 1 commits behind head on devel.

@@            Coverage Diff             @@
##            devel    #1242      +/-   ##
==========================================
+ Coverage   41.00%   41.64%   +0.63%     
==========================================
  Files          45       48       +3     
  Lines        9295     9875     +580     
==========================================
+ Hits         3811     4112     +301     
- Misses       5196     5469     +273     
- Partials      288      294       +6     
Files with missing lines Coverage Δ
pkg/types/main.go 27.45% <100.00%> (+27.45%) ⬆️

... and 5 files with indirect coverage changes

Components Coverage Δ
Go 41.16% <100.00%> (+0.16%) ⬆️
Receptorctl 49.31% <ø> (∅)

Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit d58d273 into ansible:devel Dec 13, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants