cmd: Add unit tests and fix WebSocket path default #1312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds unit tests for the cmd package, improving test coverage from 0% to 50.5%. The tests cover configuration parsing, default settings, and command execution flow. Key changes: - Add tests for configuration functions and utility methods - Fix bug in SetWSListenerDefaults where it incorrectly set BindAddr instead of Path for empty paths - Add test infrastructure including mock implementations - Skip complex tests that require additional setup for future implementation The WebSocket path bug fix ensures that when a WebSocket listener is configured without specifying a path, it correctly defaults to '/' instead of incorrectly setting the BindAddr field.
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests for the cmd package to boost test coverage to 50.5% while also fixing the bug in SetWSListenerDefaults that incorrectly set the BindAddr instead of the WebSocket path.
- Added tests for configuration parsing, default settings, and command execution flow
- Fixed the WebSocket listener default by setting the Path to "/" instead of modifying BindAddr
- Established test infrastructure with mocking and skipped tests for more complex setups
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/root_test.go | Added tests for config initialization and command execution, with skipped tests where needed |
| cmd/defaults_test.go | Included unit tests for defaults on listeners and peers |
| cmd/defaults.go | Fixed the WebSocket listener default by updating the Path assignment |
| cmd/config_test.go | Added tests for receptor configuration parsing and command phase execution |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## devel #1312 +/- ##
==========================================
+ Coverage 41.70% 43.59% +1.88%
==========================================
Files 45 48 +3
Lines 9454 10034 +580
==========================================
+ Hits 3943 4374 +431
- Misses 5220 5366 +146
- Partials 291 294 +3
... and 10 files with indirect coverage changes
🚀 New features to boost your workflow:
|
- Add periods to comments
- Add blank lines before return statements
- Replace 'else { if ... }' with 'else if ...'
- Skip tests that require cobra import to avoid depguard violations
|
arrestle
pushed a commit
to arrestle/receptor
that referenced
this pull request
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds unit tests for the cmd package, improving test coverage from 0% to 50.5%. The tests cover configuration parsing, default settings, and command execution flow.
Key changes:
The WebSocket path bug fix ensures that when a WebSocket listener is configured without specifying a path, it correctly defaults to '/' instead of incorrectly setting the BindAddr field.