Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default data directory and add checks to ensure it is writable #902

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Change default data directory and add checks to ensure it is writable #902

merged 2 commits into from
Jan 16, 2024

Conversation

AaronH88
Copy link
Contributor

@AaronH88 AaronH88 commented Dec 7, 2023

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2050e42) 33.33% compared to head (52de323) 33.44%.

@@            Coverage Diff             @@
##            devel     #902      +/-   ##
==========================================
+ Coverage   33.33%   33.44%   +0.10%     
==========================================
  Files          40       40              
  Lines        7409     7422      +13     
==========================================
+ Hits         2470     2482      +12     
- Misses       4795     4796       +1     
  Partials      144      144
Files Coverage Δ
pkg/workceptor/workceptor.go 18.66% <82.35%> (+1.73%) ⬆️

... and 2 files with indirect coverage changes

@AaronH88 AaronH88 force-pushed the receptor_data_dir branch 2 times, most recently from dc42e1e to bab9852 Compare December 7, 2023 14:22
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

matoval
matoval approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@matoval matoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronH88 AaronH88 merged commit 5cc71c0 into ansible:devel Jan 16, 2024
15 checks passed
AaronH88 added a commit to AaronH88/receptor that referenced this pull request Jan 22, 2024
@AaronH88
Revert: Change default data directory ansible#902
f8f2e78
AaronH88 added a commit that referenced this pull request Jan 22, 2024
@AaronH88
Revert: Change default data directory #902
6746592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matoval matoval matoval approved these changes

@resoluteCoder resoluteCoder resoluteCoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AaronH88 @resoluteCoder @matoval