This repository was archived by the owner on Sep 16, 2020. It is now read-only.
Make import of 'inventory' groups possible#585
Open
jomeier wants to merge 1 commit intoansible:masterfrom
Open
Make import of 'inventory' groups possible#585jomeier wants to merge 1 commit intoansible:masterfrom
jomeier wants to merge 1 commit intoansible:masterfrom
Conversation
Author
|
I have no idea how to increase the code coverage. I only added one line of code with a variable assignment :-) |
Member
|
If you add a line of code, then you increase the denominator for the code coverage calculation. All it means here is that the linear block of code where you added the line doesn't have coverage. For this, it's not a concern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm working on an tower export/import script and try to use tower-cli for that.
I described in this bug report that an import of inventories with groups and hosts in it will fail, because the group arrays don't have a 'name' field:
#582
This PR fixes that. Import of inventories with
now works.
I would be glad if someone could check that and accept this PR.
Thanks and best regards,
Josef