Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all the CI and developer configurations #293

Merged
merged 6 commits into from
May 28, 2024

Conversation

cidrblock
Copy link
Collaborator

@cidrblock cidrblock commented May 28, 2024

Align the follow configurations to ADE

  • tox.ini and tox.yml
  • precommit
  • ruff, pylint, mypy, pydocstyle
  • VsCode settings and extensions
  • Test requirements
  • CODEOWNERS
  • constraints updates as needed

Note- the pydoclint config in the flake8 file is wrong, doc string updates to follow in a different PR
Note- added some noqas for ruff base don newe findings
Note- pylint useless upressions removed
Note- Run time config for core and python version are out of date, but also out of scope for this PR, follow up coming later

Closes #267

@cidrblock cidrblock requested a review from ssbarnea as a code owner May 28, 2024 17:40
@github-actions github-actions bot added the bug This issue/PR relates to a bug. label May 28, 2024
@cidrblock cidrblock changed the title All the CI and dev updates Update all the CI and developer configurations May 28, 2024
@cidrblock
Copy link
Collaborator Author

monir coverage change, ignoring

@cidrblock
Copy link
Collaborator Author

tox_passed is a legacy check, it has since been disabled

@cidrblock
Copy link
Collaborator Author

These changes have been reviewed in other repos, so self approving

@cidrblock cidrblock merged commit 2ae824d into ansible:main May 28, 2024
14 of 15 checks passed
@ssbarnea ssbarnea added skip-changelog Can be missed from the changelog. and removed bug This issue/PR relates to a bug. labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Can be missed from the changelog.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants