-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add field in SaveFile_Request to save speos light box from scene #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 303fcc1.
jomadec
reviewed
Feb 9, 2026
echambla
reviewed
Feb 9, 2026
jomadec
previously approved these changes
Feb 9, 2026
nicolasANSS
reviewed
Feb 9, 2026
Co-authored-by: nicolasANSS <152977068+nicolasANSS@users.noreply.github.com>
Co-authored-by: nicolasANSS <152977068+nicolasANSS@users.noreply.github.com>
jomadec
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to improve the service SceneActions::SaveFile in order to save a scene into speos light box.
We add following fiel in SaveFile_Request message:
These fields are only necessary if user want save a speos light box.