Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: named selection functionality #1768

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

feat: named selection functionality #1768

wants to merge 30 commits into from

Conversation

jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Feb 21, 2025 •
edited
Loading

Description

  • move_rotate / move_translate implemented to transform named selections
  • enhanced reading existing designs to take more information from named selections
  • enhanced creating new name selections from client-side designs

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

jkerstet added 4 commits February 18, 2025 11:26
added properties
bd9e051 
need read existing design functionality
tested named selection import
da25a31
able to query named_selections for underlying members
ef8b880
implemented named selection from existing design
2b9b695 
implemented MoveRotate and MoveTranslate for named selections
@jacobrkerstetter jacobrkerstetter self-assigned this Feb 21, 2025
@jacobrkerstetter jacobrkerstetter changed the title feat: Named Selection Functionality feat: named selection functionality Feb 21, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Feb 21, 2025
@jacobrkerstetter jacobrkerstetter marked this pull request as ready for review February 24, 2025 16:20
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner February 24, 2025 16:20
jkerstet and others added 13 commits February 25, 2025 09:17
- fixed move_rotate and move_translate proto naming
a8ff440 
- fixed logic for creating new NS so the create command is only called once
@pre-commit-ci
chore: auto fixes from pre-commit hooks
a2cc30f
@jacobrkerstetter
Merge branch 'main' into feat/named_selection_functionality
04af7d0
edited test because order of id's is not constant
6d9b804
Merge branch 'feat/named_selection_functionality' of https://github.c…
3768b9c 
…om/ansys/pyansys-geometry into feat/named_selection_functionality
- removed a few NS from the test file for speed of testing
18b358a 
- added more rigorous testing by querying a face for area
- altered how the face/body/edge objects are populated for NS
@jacobrkerstetter
Merge branch 'main' into feat/named_selection_functionality
ff262a9
@pre-commit-ci
chore: auto fixes from pre-commit hooks
e9647ff
precommit fix
cb3ecc7
merge error fix
999cc3f
accepting distance object for offset_faces_set_radius
00e433d
updated docstring
ebbe4cb
@pre-commit-ci
chore: auto fixes from pre-commit hooks
ed0383a
@codecov Codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.15789% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.90%. Comparing base (cdd6dc4) to head (b8e838f).

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/selection.py 75.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1768      +/-   ##
==========================================
+ Coverage   90.88%   90.90%   +0.02%     
==========================================
  Files          92       92              
  Lines        8357     8423      +66     
==========================================
+ Hits         7595     7657      +62     
- Misses        762      766       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RobPasMue
RobPasMue reviewed Feb 27, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good! Left some comments, request review again once addressed

src/ansys/geometry/core/designer/design.py
bodies=bodies,
faces=faces,
edges=edges,
beams=[beam.id for beam in result.beams],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be Beam objects, not just IDs.

@RobPasMue RobPasMue linked an issue Feb 27, 2025 that may be closed by this pull request
NamedSelection class should contain the members of the Named Selection #1101
Open
@RobPasMue RobPasMue mentioned this pull request Feb 27, 2025
Open
jkerstet and others added 4 commits February 27, 2025 10:56
- edited model
1558093 
- adjusted import test for new model
- added Quantity input type for new geometry commands
- adjusted NamedSelection constructor -- beams still a question
Merge branch 'feat/named_selection_functionality' of https://github.c…
adf96d6 
…om/ansys/pyansys-geometry into feat/named_selection_functionality
@pre-commit-ci
chore: auto fixes from pre-commit hooks
fc53f96
@jacobrkerstetter
Merge branch 'main' into feat/named_selection_functionality
b8e838f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue requested changes

@jonahrb jonahrb Awaiting requested review from jonahrb

Requested changes must be addressed to merge this pull request.

Assignees

@jacobrkerstetter jacobrkerstetter

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NamedSelection class should contain the members of the Named Selection
3 participants
@jacobrkerstetter @RobPasMue @pyansys-ci-bot