Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Streaming upload support #1779

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: Streaming upload support #1779

wants to merge 7 commits into from

Conversation

mlkaplan36
Copy link
Contributor

@mlkaplan36 mlkaplan36 commented Feb 25, 2025 •
edited by RobPasMue
Loading

Description

Client side support for streaming files to the server.
"chunk_size" in _generate_file_chunks is currently hard-coded to 64kb (the gRPC recommended size) but can be easily changed.

Issue linked

Closes #1765, #1778

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@mlkaplan36 mlkaplan36 self-assigned this Feb 25, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Feb 25, 2025
This was linked to issues Feb 26, 2025
Error on opening a cad file with size ~280 MB #1765
Closed
Enable streaming for upload/download of file #1778
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue Awaiting requested review from RobPasMue

@jonahrb jonahrb Awaiting requested review from jonahrb

@jacobrkerstetter jacobrkerstetter Awaiting requested review from jacobrkerstetter

@jrwest440 jrwest440 Awaiting requested review from jrwest440

@RyanJWard RyanJWard Awaiting requested review from RyanJWard

At least 1 approving review is required to merge this pull request.

Assignees

@mlkaplan36 mlkaplan36

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable streaming for upload/download of file Error on opening a cad file with size ~280 MB
2 participants
@mlkaplan36 @pyansys-ci-bot