Skip to content

Conversation

jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Sep 16, 2025

Description

these export methods were originally missed when adding this parameter

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb self-assigned this Sep 16, 2025
@jonahrb jonahrb requested a review from a team as a code owner September 16, 2025 14:45
@github-actions github-actions bot added the bug Something isn't working label Sep 16, 2025
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.15%. Comparing base (0bfefb6) to head (10e88fc).

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/design.py 75.00% 1 Missing ⚠️

❌ Your project check has failed because the head coverage (86.15%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (0bfefb6) and HEAD (10e88fc). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (0bfefb6) HEAD (10e88fc)
6 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2231      +/-   ##
==========================================
- Coverage   94.73%   86.15%   -8.58%     
==========================================
  Files         142      140       -2     
  Lines       10615    10592      -23     
==========================================
- Hits        10056     9126     -930     
- Misses        559     1466     +907     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

RobPasMue
RobPasMue previously approved these changes Sep 16, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants