feat: move geometry commands to versioned architecture #2234
+2,315
−468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
… feat/geometry_commands_restructure # Conflicts: # src/ansys/geometry/core/designer/geometry_commands.py
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2234 +/- ##
==========================================
+ Coverage 94.50% 94.57% +0.07%
==========================================
Files 142 157 +15
Lines 10585 10883 +298
==========================================
+ Hits 10003 10293 +290
- Misses 582 590 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… feat/geometry_commands_restructure
RobPasMue
requested changes
Sep 23, 2025
|
Adding comment to keep track of modules reviewed:
|
RobPasMue
reviewed
Sep 24, 2025
|
|
||
| self._grpc_client.log.debug(f"Creating beams on {self.id}...") | ||
| response = self._commands_stub.CreateBeamSegments(request) | ||
| response = self._grpc_client.services.beams.create_beam_segments( |
There was a problem hiding this comment.
Just remembered, for beams, remove the unnecessary "protect_grpc" statements on the create_beams wrapper method in this module!
| # as for deleting a Body | ||
| # | ||
| self._commands_stub.DeleteBeam(EntityIdentifier(id=beam_requested.id)) | ||
| self._grpc_client.services.beams.delete_beam(beam_id=beam_requested.id) |
There was a problem hiding this comment.
Delete protect_grpc from this method
| return {} | ||
|
|
||
| @protect_grpc | ||
| def split_body(self, **kwargs): # noqa: D102 |
| raise NotImplementedError | ||
|
|
||
| @protect_grpc | ||
| def split_body(self, **kwargs): # noqa: D102 |
There was a problem hiding this comment.
Missing dict type hint on return
Comment on lines
554
to
+556
| ---------- | ||
| selection : list[Body] | list[Component] | list[Face] | list[Edge] | ||
| Selection of the object to rename. | ||
| selection : list[Body] | list[Component] | ||
| Selection of the objects to rename. |
There was a problem hiding this comment.
Interesting... renaming does not apply to Face or Edge objects?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue linked
#1817
Checklist
feat: extrude circle to cylinder)