chore: Client Typing Fixes #4500
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gobot1234
requested review from
mkundu1,
seanpearsonuk,
prmukherj,
hpohekar and
mayankansys
as code owners
|
Thanks for addressing these issues. I enabled the checks to run. FYI it's thrown up this issue: "Smoke test failed for package 'ansys-fluent-core' with error: cannot import name 'Unpack' from 'typing'" |
|
@Gobot1234 The changes looks good. Can you please create the changes within a branch in the pyfluent repo, so I can try them out locally? Please also add yourself to ansys org, so that I can add you in the pyfluent repo. |
|
Ah right didn't realise it wasn't a create your own fork kinda thing. Will do tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the unrelated changes from my main branch, I'll rebase once they're merged.
I've done a few things here, it's all to get stuff around the launchers typed in the hopes of being able to get LSP tests that pass.
Hopefully along with the workflow/meshing changes this should get rid of most of the typing errors in the public API