Update python keycloak #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
+ Coverage 92.82% 92.84% +0.01%
==========================================
Files 61 61
Lines 2258 2277 +19
==========================================
+ Hits 2096 2114 +18
- Misses 162 163 +1 ☔ View full report in Codecov by Sentry. |
PipKat
reviewed
Mar 4, 2024
| @@ -164,26 +168,28 @@ def delete_user(self, user: User) -> None: | |||
| return self.keycloak_admin_client.delete_user(user.id) | |||
|
|
|||
|
|
|||
| def _admin_client(client): | |||
| def _admin_client(client: "Client"): | |||
| """Set information for admin. | |||
There was a problem hiding this comment.
Descriptions should be in plain English. Spell out "admin" to "administrator" if that is what is meant.
|
abandoning in favor of #352 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
python-keycloakversions < 3.9.1 depend onpython-josewhich in turn depends onecdsa, which has safety vulnerabilitiespython-keycloak >= 3.9.1replacedpython-josewithjwcryptowhich is LGPL.