Skip to content

Fix issue 4206 #4207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix issue 4206 #4207

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c0fb6a
Initial fix in interp_star_status function
ChaiF1 Aug 29, 2025
028f770
Removed junk lines and fixed a typo
ChaiF1 Aug 29, 2025
016cbc3
ci: auto fixes from pre-commit.com hooks.
pre-commit-ci[bot] Aug 29, 2025
f719869
Merge branch 'main' into Fix_issue_4206
ChaiF1 Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ansys/mapdl/core/parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,6 +853,8 @@ def interp_star_status(status):
"type": items[1],
"workspace": int(items[4]),
}
elif items[1] in ["C_FullFile"]:
Copy link
Preview

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a list with a single element for string comparison is unnecessary. Consider using a direct string comparison: elif items[1] == "C_FullFile": for better readability and performance.

Suggested change
elif items[1] in ["C_FullFile"]:
elif items[1] == "C_FullFile":

Copilot uses AI. Check for mistakes.

Copy link
Preview

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dictionary structure is inconsistent with other parameter types above, which include additional fields like 'workspace' or 'shape'. Consider adding a comment explaining why C_FullFile parameters only need the type field, or ensure consistency with the expected parameter structure.

Suggested change
elif items[1] in ["C_FullFile"]:
elif items[1] in ["C_FullFile"]:
# C_FullFile parameters only require the 'type' field.
# No additional fields (e.g., 'workspace', 'shape') are needed for this type.

Copilot uses AI. Check for mistakes.

parameters[name] = {"type": items[1]}
else:
shape = (int(items[2]), int(items[3]), int(items[4]))
parameters[name] = {"type": items[1], "shape": shape}
Expand Down