-
Notifications
You must be signed in to change notification settings - Fork 139
feat: add STATUS enum for MAPDL state management #4221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a STATUS enum to replace string literals for MAPDL state management, improving type safety and code maintainability. The changes move from magic strings like "exited", "exiting", and "OK" to well-defined enum values.
- Adds a STATUS enum with EXITED, EXITING, and RUNNING values
- Updates the check_status property to use enum values instead of strings
- Improves type annotation by specifying STATUS as the return type
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…-enums-for-status
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4221 +/- ##
==========================================
- Coverage 91.39% 91.31% -0.08%
==========================================
Files 193 193
Lines 15715 15720 +5
==========================================
- Hits 14362 14355 -7
- Misses 1353 1365 +12 🚀 New features to boost your workflow:
|
@pyansys-ci-bot LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Use enum instead of just strings.
Issue linked
NA
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)