Skip to content

Conversation

@EmilyyyLiu
Copy link
Contributor

统一添加自定义class 前缀
关联issue #6960

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

Preview failed

@gemini-code-assist
Copy link

Summary of Changes

Hello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求引入了一个统一的机制,用于为组件提供自定义的类名前缀,并以 Avatar 组件作为首个适配对象。通过集成到 ConfigProvider 中,开发者可以灵活地全局或针对特定组件定制类名,从而增强样式控制能力并有效避免潜在的 CSS 命名冲突。

Highlights

  • 统一类名前缀管理: ConfigProvider 现在支持 prefixCls 属性,允许全局设置组件的类名前缀,从而提供更灵活的样式定制能力。
  • Avatar 组件适配: Avatar 组件已更新,不再使用硬编码的类名前缀,而是利用 ConfigProvider 提供的 getPrefixCls 方法来动态生成其类名。
  • 类名前缀优先级: 新引入的 getPrefixCls 方法实现了类名前缀的优先级逻辑:组件直接传入的 prefixCls 优先于 ConfigProvider 的设置,而 ConfigProvider 的设置又优先于默认值 adm
  • 测试与文档更新: 增加了新的测试用例和快照,以验证自定义 prefixCls 的行为,并更新了中英文文档,详细说明了 ConfigProvider 的新属性。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Oct 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the feature label Oct 21, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 21, 2025

npm i https://pkg.pr.new/ant-design/ant-design-mobile/antd-mobile@6964

commit: 8cd355b

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a new prefixCls prop to the Avatar component, allowing for custom class name prefixes to be applied. This change also modifies the ConfigProvider to handle the new prefixCls and provides a getPrefixCls function to generate class names. Tests have been added to verify the functionality of the new prefixCls prop.

import Image, { ImageProps } from '../image'
import { Fallback } from './fallback'

const classPrefix = 'adm-avatar'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The classPrefix constant is no longer used. It should be removed to avoid confusion and reduce unnecessary code.

prefixCls?: string
getPrefixCls: GetPrefixCls
}
export const defaultPrefixCls = 'adm'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider using const instead of export const if defaultPrefixCls is not intended to be modified outside of this module. This can help prevent accidental modifications and improve code maintainability.

Suggested change
export const defaultPrefixCls = 'adm'
const defaultPrefixCls = 'adm'

})
})

test('useConfig should only has `locale`', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test description is slightly inaccurate. It should be updated to reflect that useConfig now also includes getPrefixCls.

Suggested change
test('useConfig should only has `locale`', () => {
test('useConfig should only has `locale` and `getPrefixCls`', () => {

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.97%. Comparing base (bfde19d) to head (8cd355b).

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #6964      +/-   ##
===========================================
+ Coverage    92.95%   92.97%   +0.01%     
===========================================
  Files          337      337              
  Lines         7368     7370       +2     
  Branches      1871     1835      -36     
===========================================
+ Hits          6849     6852       +3     
- Misses         483      510      +27     
+ Partials        36        8      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EmilyyyLiu EmilyyyLiu force-pushed the feature-prefixCls-avatar branch from 3bd36d1 to 8cd355b Compare October 23, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant