-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(Avatar): unified provision of custom prefixCls #6964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求引入了一个统一的机制,用于为组件提供自定义的类名前缀,并以 Avatar 组件作为首个适配对象。通过集成到 ConfigProvider 中,开发者可以灵活地全局或针对特定组件定制类名,从而增强样式控制能力并有效避免潜在的 CSS 命名冲突。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces a new prefixCls prop to the Avatar component, allowing for custom class name prefixes to be applied. This change also modifies the ConfigProvider to handle the new prefixCls and provides a getPrefixCls function to generate class names. Tests have been added to verify the functionality of the new prefixCls prop.
| import Image, { ImageProps } from '../image' | ||
| import { Fallback } from './fallback' | ||
|
|
||
| const classPrefix = 'adm-avatar' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| prefixCls?: string | ||
| getPrefixCls: GetPrefixCls | ||
| } | ||
| export const defaultPrefixCls = 'adm' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| }) | ||
| }) | ||
|
|
||
| test('useConfig should only has `locale`', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature #6964 +/- ##
===========================================
+ Coverage 92.95% 92.97% +0.01%
===========================================
Files 337 337
Lines 7368 7370 +2
Branches 1871 1835 -36
===========================================
+ Hits 6849 6852 +3
- Misses 483 510 +27
+ Partials 36 8 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3bd36d1 to
8cd355b
Compare

统一添加自定义class 前缀
关联issue #6960