fix: change walletsListSource URL to scalable #1525
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dosubot
bot
added
the
size:XS
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @sraibaby, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the source URL for the TON wallet list within the Ant Design Web3 documentation. The change aims to improve the reliability and scalability of accessing the list of supported TON wallets by switching from a direct GitHub raw content link to a Vercel-hosted endpoint.
Highlights
- Wallet List URL Update: The URL for the TON wallet list, referenced in both English and Chinese Ant Design Web3 documentation, has been updated to a new, potentially more scalable source hosted on Vercel.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the URL for the TON wallet list in the documentation to a new endpoint for scalability. However, the new URL points to a temporary, personal Vercel deployment. This introduces significant security and reliability risks and is not a scalable solution. My review suggests using a public CDN like jsDelivr as a more appropriate and robust alternative. I also pointed out that this change creates an inconsistency in the documentation, as another reference to the same URL was not updated.
| The interface design of `@ant-design/web3-ton` refers to the [TON official documentation](https://docs.ton.org/) and `@tonconnect/sdk`. You can find more in-depth implementation details in the documentation. The RPC service (such as balance inquiry) uses [Tonconnect](http://toncenter.com), including the testnet and mainnet. | ||
|
|
||
| You can check the wallets supported by Ton in the [Wallet Interface](https://raw.githubusercontent.com/ton-blockchain/wallets-list/main/wallets-v2.json). Ant Design Web3 provides settings for some commonly used wallets, as follows: | ||
| You can check the wallets supported by Ton in the [Wallet Interface](https://whatever-zeta-two.vercel.app/wallets-v2.json). Ant Design Web3 provides settings for some commonly used wallets, as follows: |
There was a problem hiding this comment.
The new URL https://whatever-zeta-two.vercel.app/wallets-v2.json appears to be a temporary Vercel deployment endpoint, which is not suitable for production documentation. This change introduces several issues:
- Security Risk: It points to an unofficial and untrusted source for the wallet list. A compromised endpoint could serve a malicious list, leading to phishing attacks.
- Reliability: A temporary deployment URL is not stable and can be taken down at any time, leading to broken links.
- Scalability: Contrary to the PR title, a personal Vercel deployment is not a scalable solution and is less reliable than the original GitHub source.
For a truly scalable and reliable solution, consider using a public CDN that mirrors GitHub content, like jsDelivr. The URL would be https://cdn.jsdelivr.net/gh/ton-blockchain/wallets-list@main/wallets-v2.json.
Furthermore, this change creates an inconsistency, as the walletsListSource default value in the table on line 47 of this file still points to the old GitHub URL.
| You can check the wallets supported by Ton in the [Wallet Interface](https://whatever-zeta-two.vercel.app/wallets-v2.json). Ant Design Web3 provides settings for some commonly used wallets, as follows: | |
| You can check the wallets supported by Ton in the [Wallet Interface](https://cdn.jsdelivr.net/gh/ton-blockchain/wallets-list@main/wallets-v2.json). Ant Design Web3 provides settings for some commonly used wallets, as follows: |
| `@ant-design/web3-ton` 的接口设计参考了 [TON 官方文档](https://docs.ton.org/mandarin/)和`@tonconnect/sdk`，你可以在文档中找到更加深层的实现原理。RPC 服务（比如说查询余额）采用的是 [Tonconnect](http://toncenter.com)，包括测试网以及主网。 | ||
|
|
||
| Ton 支持的钱包可以在 [钱包接口](https://raw.githubusercontent.com/ton-blockchain/wallets-list/main/wallets-v2.json) 中查看，Ant Design Web3 提供了部分常用钱包的设置，如下： | ||
| Ton 支持的钱包可以在 [钱包接口](https://whatever-zeta-two.vercel.app/wallets-v2.json) 中查看，Ant Design Web3 提供了部分常用钱包的设置，如下： |
There was a problem hiding this comment.
The new URL https://whatever-zeta-two.vercel.app/wallets-v2.json appears to be a temporary Vercel deployment endpoint, which is not suitable for production documentation. This change introduces several issues:
- Security Risk: It points to an unofficial and untrusted source for the wallet list. A compromised endpoint could serve a malicious list, leading to phishing attacks.
- Reliability: A temporary deployment URL is not stable and can be taken down at any time, leading to broken links.
- Scalability: Contrary to the PR title, a personal Vercel deployment is not a scalable solution and is less reliable than the original GitHub source.
For a truly scalable and reliable solution, consider using a public CDN that mirrors GitHub content, like jsDelivr. The URL would be https://cdn.jsdelivr.net/gh/ton-blockchain/wallets-list@main/wallets-v2.json.
Furthermore, this change creates an inconsistency, as the walletsListSource default value in the table on line 47 of this file still points to the old GitHub URL.
| Ton 支持的钱包可以在 [钱包接口](https://whatever-zeta-two.vercel.app/wallets-v2.json) 中查看，Ant Design Web3 提供了部分常用钱包的设置，如下： | |
| Ton 支持的钱包可以在 [钱包接口](https://cdn.jsdelivr.net/gh/ton-blockchain/wallets-list@main/wallets-v2.json) 中查看，Ant Design Web3 提供了部分常用钱包的设置，如下： |
1 participant
No description provided.