Fix PHP 8.4 deprecation.

[kagg-design]

Fixed: "Deprecated: str_getcsv(): the $escape parameter must be provided as its default value will change."

[jrfnl]

Nice find!

My two pennies:

I think the @noinspection comment should probably be removed as that is an IDE specific thing.

I'd also like to see at least one test covering this change to safeguard it for the future.

[kagg-design]

Hi @jrfnl! Thank you for your comment.

I have removed // @noinspection ... line.

Concerning tests, I have the following thoughts.

1. This is pure refactoring.
2. As far as I can see, this method was not covered by tests, so should I write a new test for it?
3. This line is called 19 times during tests of the Function Mocker; you can see my merged PR with 8.4 updates for it. Should it be considered as enough check?

Thank you.

[jrfnl]

Concerning tests, I have the following thoughts.

1. This is pure refactoring.
2. As far as I can see, this method was not covered by tests, so should I write a new test for it?
3. This line is called 19 times during tests of the Function Mocker; you can see my merged PR with 8.4 updates for it. Should it be considered as enough check?

@kagg-design Sorry, but no, tests in an external project should - IMO - definitely not be considered enough of a check.

The existing tests for this package are currently passing on PHP 8.4, so this means this code is currently not covered by tests. And even though I checked both the tests and did various scans on the code base with tooling when preparing for PHP 8.4 (see #157, #160, #161, #165, #166), this one wasn't found as it was "hidden" in a callback string.

Considering PHP intends to make further changes to this function in future PHP versions (based on the RFC and discussions I've had about this in the PHP src GH PR and the Internals mailing list), I think it is only prudent to make sure the code is covered by tests in this project to be sure that, when the next change lands in PHP, we can verify things continue to work as expected.

Aside from that, having a test in place will also safeguard that someone doesn't accidentally remove the fix at some point in the future.

[kagg-design]

Hi @jrfnl, I have added the test.

[jrfnl]

@antecedent Was just having another look at this, but the test as it currently is, would not hit the PHP 8.4 deprecation notice (without the fix in place), so it's not safeguarding the change correctly. Digging in deeper now.

[jrfnl]

I've opened PR #171 to fix the test.