refactor: reduce installation size by replacing pacote
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing, converting the PR to draft now. |
|
All tests pass on my machine, the PR is ready for review now @antfu 
|
SukkaW
commented
Apr 13, 2024
Comment on lines
+28
to
+30
| // @types/pacote uses "import = require()" syntax which is not supported by unbuild | ||
| // So instead of using @types/pacote, we declare the type definition with only fields we need | ||
| export interface Packument { |
There was a problem hiding this comment.
Previously, pacote was a direct dependency.
If pacote is removed, @types/pacote can not live alone, and import = require() would cause the build to fail, hence the manual declaration.
antfu
approved these changes
Apr 13, 2024
SukkaW
changed the title
pacotepacote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the installation size of
tazeis 14 MiB, twice the size ofnpm-check-updatedwhich is 7.3 MiB.It turns out that the
pacotecould be the culprit.pacoteintroduces tons of npm core functionality whiletazeonly utilize its package metadata fetching.Linked Issues
N/A
Additional context
See also antfu-collective/unconfig#27