Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): use node lts/* #110

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Apr 16, 2024

Description

The CI of #109 failed due to the outdated version of Node.js used to run the lint workflow. The PR updates the GitHub Action to fix that.

Linked Issues

#109

Additional context

N/A

@SukkaW SukkaW force-pushed the ci-lint-node-lts branch from 6aca9d5 to 3bffa7a Compare April 16, 2024 03:35
@SukkaW SukkaW changed the title ci(lint): use node lts ci(lint): use node latest Apr 16, 2024
with:
node-version: 16.x
node-version: latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
node-version: latest
node-version: lts/*

Maybe lts would be a better target

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I willupdate the typecheck action below as well.

@SukkaW SukkaW changed the title ci(lint): use node latest ci(lint): use node lts/* Apr 16, 2024
@SukkaW SukkaW requested a review from antfu April 16, 2024 03:59
@antfu antfu merged commit 69802d3 into antfu-collective:main Apr 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants